Slim-Skeleton icon indicating copy to clipboard operation
Slim-Skeleton copied to clipboard

Fixed "ERROR: Using ${var} in strings is deprecated, use {$var} instead" and added logError and logErrorDetails variables on the Shutdown handler

Open AntoninoM90 opened this issue 2 years ago • 4 comments

Fixed php error on view user action (src\Application\Actions\User\ViewUserAction.php):

ERROR: Using ${var} in strings is deprecated, use {$var} instead"

AntoninoM90 avatar Apr 01 '24 22:04 AntoninoM90

Why "Tests / Tests PHP 8.1 (pull_request)" is failed?

AntoninoM90 avatar Apr 07 '24 14:04 AntoninoM90

Why "Tests / Tests PHP 8.1 (pull_request)" is failed?

Because of using more than one whitespace between the return type declaration and the variable in a function signature. That may look better, but is against the coding guidelines here…

EDITed this post: The stuff I wrote before seems to be against the coding guidelines seems legitimate and isn't what's in question here.

carlosmintfan avatar Apr 26 '24 18:04 carlosmintfan

I fixed the php 8.1 test issues but now I'm getting a new error from Coveralls, why?

AntoninoM90 avatar May 15 '24 11:05 AntoninoM90

Because the new changes aren't covered in the unit tests...but I'm not sure if we should do it that way. If the error given to the shutdown handler is an error in the logger itself, we shouldn't give it to the logger. On the other hand, if it wasn't, we should, so I think we should make some try/catch around it. (Only my personal view, not a maintainer.)

carlosmintfan avatar May 17 '24 21:05 carlosmintfan