python-google-places icon indicating copy to clipboard operation
python-google-places copied to clipboard

Published 20 hours ago • verified publisher icon slimkrazy

Fix for a valid nearby_search that was throwing an error unnecessarily.

Open kingb opened this issue 11 years ago • 2 comments

  • name, lat_lng, radius, and rankby=ranking.DISTANCE.
    • Test for error was:
      • if keyword is None and types == []
    • Should be:
      • if keyword is None and types == [] and name is None

kingb avatar Jun 27 '13 23:06 kingb

Sorry for the delay - I can't even begin to explain how busy I've been.

I'll going to spend some time updating this from this weekend - I'll be sure to include your fix.

Thanks!

slimkrazy avatar Sep 05 '13 07:09 slimkrazy

No worries at all! Take your time, I understand being busy.

Can you double check Radar Feature before merging it? I'm not 100% sure it's needed after I did more work... I think more work might need to be done to make it work. It's been awhile since I worked on it. I think it turned out the results returned less attributes than other queries which may have led to errors being thrown when trying to use the returned data. I'd have to double check. Ah, right, I included the FIXMEs in the commit that described some of the issues. Anyway, let me know if you have an questions and I'll look into this some more if you do.

-Brandon

kingb avatar Sep 05 '13 19:09 kingb