Add support for UNIX domain sockets
This adds support for UNIX domain sockets and makes them the only option on platforms and Common Lisps that support them.
There are still bugs:
- The temporary files are not deleted when SLIME exits. Note that these will be deleted in the event of a PID clash.
- TCP sockets are still completely insecure.
Temp files deletion fixed, but I can't understand why I broke the test suite.
Test suite fixed. ~/.slime-secret support is broken though.
I just realized a problem: this relies on Emacs for temporary file handling. So it won't work in the case of a remote Swank being started outside of Emacs.
@DemiMarie do we fallback to TCP in that case?
This patch doesn't have a fallback, for security reasons. I can remove the dependency when done with an exam.
For remote debugging, my plan is to use SSH to handle communication.
On Oct 10, 2016 7:11 AM, "Luís Oliveira" [email protected] wrote:
@DemiMarie https://github.com/DemiMarie do we fallback to TCP in that case?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/slime/slime/pull/291#issuecomment-252589295, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGWBysUMhu_hWeik9POxlPnok8Jwe1gks5qyh1bgaJpZM4G9Fcb .
Fallback was a bad choice of words. I meant, can we pass a specific :tcp or :unix option to create-server? :unix would be the default, and SLIME can invoke it with :unix when applicable.
BTW, creating a local swank server is useful for situations other than remote debugging.
Any chance of getting this pulled soon?
This pull request removes the ability to open a SWANK server using TCP on Unix. I don't think that's reasonable. It needs be updated so that users can choose whether they want TCP or UNIX_AF. I'm fine with SLIME defaulting to opening using UNIX_AF by default, when available.
What's the current status of this PR?
What's the current status of this PR?
I am no longer working on it as I quit using Common Lisp years ago. If someone else wants to work on it, that would be great!