slime icon indicating copy to clipboard operation
slime copied to clipboard

Add support for UNIX domain sockets

Open DemiMarie opened this issue 10 years ago • 10 comments

This adds support for UNIX domain sockets and makes them the only option on platforms and Common Lisps that support them.

There are still bugs:

  • The temporary files are not deleted when SLIME exits. Note that these will be deleted in the event of a PID clash.
  • TCP sockets are still completely insecure.

DemiMarie avatar Dec 31 '15 03:12 DemiMarie

Temp files deletion fixed, but I can't understand why I broke the test suite.

DemiMarie avatar Feb 25 '16 02:02 DemiMarie

Test suite fixed. ~/.slime-secret support is broken though.

DemiMarie avatar Jun 02 '16 03:06 DemiMarie

I just realized a problem: this relies on Emacs for temporary file handling. So it won't work in the case of a remote Swank being started outside of Emacs.

DemiMarie avatar Oct 09 '16 19:10 DemiMarie

@DemiMarie do we fallback to TCP in that case?

luismbo avatar Oct 10 '16 11:10 luismbo

This patch doesn't have a fallback, for security reasons. I can remove the dependency when done with an exam.

For remote debugging, my plan is to use SSH to handle communication.

On Oct 10, 2016 7:11 AM, "Luís Oliveira" [email protected] wrote:

@DemiMarie https://github.com/DemiMarie do we fallback to TCP in that case?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/slime/slime/pull/291#issuecomment-252589295, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGWBysUMhu_hWeik9POxlPnok8Jwe1gks5qyh1bgaJpZM4G9Fcb .

DemiMarie avatar Oct 10 '16 14:10 DemiMarie

Fallback was a bad choice of words. I meant, can we pass a specific :tcp or :unix option to create-server? :unix would be the default, and SLIME can invoke it with :unix when applicable.

BTW, creating a local swank server is useful for situations other than remote debugging.

luismbo avatar Oct 10 '16 15:10 luismbo

Any chance of getting this pulled soon?

slyrus avatar Oct 14 '16 02:10 slyrus

This pull request removes the ability to open a SWANK server using TCP on Unix. I don't think that's reasonable. It needs be updated so that users can choose whether they want TCP or UNIX_AF. I'm fine with SLIME defaulting to opening using UNIX_AF by default, when available.

luismbo avatar Oct 14 '16 08:10 luismbo

What's the current status of this PR?

jcguu95 avatar May 13 '21 12:05 jcguu95

What's the current status of this PR?

I am no longer working on it as I quit using Common Lisp years ago. If someone else wants to work on it, that would be great!

DemiMarie avatar May 13 '21 13:05 DemiMarie