slim icon indicating copy to clipboard operation
slim copied to clipboard

test/core/test_code_evaluation.rb may require 'ostruct'

Open boutil opened this issue 3 years ago • 0 comments

Hi!

In Debian, the testsuite of your gem is run without the bundler/setup part. Everything is working fine, except one single error with 4.1.0:

  1) Error:
TestSlimCodeEvaluation#test_code_attribute_does_not_modify_argument:
NameError: uninitialized constant TestSlimCodeEvaluation::OpenStruct
    /<<PKGBUILDDIR>>/test/core/test_code_evaluation.rb:167:in `test_code_attribute_does_not_mod
ify_argument'

which is fixed by adding

require 'ostruct'

at the top of test/core/test_code_evaluation.rb.

Do you think it would be a sound change, in order to not rely on transitive require statements to ensure that OpenStruct is defined?

Thanks in advance

boutil avatar Jul 16 '22 22:07 boutil