slim icon indicating copy to clipboard operation
slim copied to clipboard

Intermittent test failures

Open thewatts opened this issue 4 years ago • 3 comments

I'm not exactly sure what could be causing this. Here is the exact line in a build.

Error:
TestSlim#test_render_thread_options:
ActionView::Template::Error: Unknown line indicator
  /home/travis/build/slim-template/slim/test/rails/app/views/layouts/application.html.slim, Line 10, Column 4
    .content= yield
    ^
    app/views/layouts/application.html.slim:10
    /home/travis/build/slim-template/slim/lib/slim/parser.rb:524:in `syntax_error!'
    /home/travis/build/slim-template/slim/lib/slim/parser.rb:265:in `unknown_line_indicator'
    /home/travis/build/slim-template/slim/lib/slim/parser.rb:256:in `parse_line_indicators'

It's failing in this test: test "render thread_options".

Sometimes this fails, sometimes it doesn't. It doesn't seem specific to any Rails or Ruby version.

I'm 100% game to look into a fix, but does anyone have a thought about what could be happening to give me a head start?

thewatts avatar Mar 21 '20 15:03 thewatts

I originally thought it was specific to my PR for Tailwind.css support #841, but it's failed on other builds as well - this example being with jruby.

thewatts avatar Mar 21 '20 15:03 thewatts

Yeah, it's always has intermitted failures for unknown reasons. Just pushed an update to dependency versions in the Gemfile to see if it addresses any of this.

stonean avatar Mar 21 '20 15:03 stonean

It passed on master (🙌), but still failed when I updated my branch.

If it weren’t failing for the same reason, I would say it’s my additions, but I’m just not sure.

thewatts avatar Mar 21 '20 17:03 thewatts

Any new insight about this issue? It still seems to happen from time to time in the test suite.

minad avatar Mar 19 '23 18:03 minad