slidewiki-platform icon indicating copy to clipboard operation
slidewiki-platform copied to clipboard

Published 20 hours ago • verified publisher icon slidewiki

Swik 2438 missing thumbnails in import preview

Open dpaun opened this issue 6 years ago • 3 comments

This is by no means critical or urgent... There are sometimes problems with getting thumbnails right after import has been completed (I guess it takes time to create thumbnails on the file service). This PR tries to solve this by retrieving thumbnail files from the file service, repeatedly, 10 times, and using base64 to show these images in a modal dialog. One way to test it and see whether it's an improvement is by showing both base64 and url (current approach) based images (uncommenting lines 117 and 122 in ImportPreviewModal.js). There are also some improvements for the import progress bar.

dpaun avatar Dec 14 '18 09:12 dpaun

@dpaun please can you resolve conflicts?

abijames avatar Dec 19 '18 08:12 abijames

Yes, of course. I've resolved conflicts.

dpaun avatar Dec 20 '18 07:12 dpaun

On testing, no thumbnails appeared (see screenshot). Suggest not merging this for now without more testing.

image

abijames avatar Dec 20 '18 10:12 abijames