slidev icon indicating copy to clipboard operation
slidev copied to clipboard

Published 20 hours ago • verified publisher icon slidevjs

HTML comments in Layout code are breaking navigation

Open mrwwalmsley opened this issue 3 years ago • 2 comments

Describe the bug HTML comments in the dynamic-image of the light icons theme was causing that slide to remain visible even when navigating to the next slide.

To Reproduce Steps to reproduce the behavior:

  1. Use the light-icons theme
  2. Create a slide with the layout: dynamic-image and left: false
  3. Create another slide after the dynamic-image layout.
  4. You can't navigate to the second slide.

Workaround

  1. Copy the dynamic-image.vue into your local layouts folder.
  2. Remove the HTML comments on line 3 and line 42
  3. Now navigation works correctly!

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
  • Slidev version: @slidev/cli: 0.22.7

mrwwalmsley avatar Aug 14 '21 00:08 mrwwalmsley

Can you share a minimal reproduction? Thanks.

antfu avatar Sep 17 '21 21:09 antfu

This seems more an issue related to the light-icons theme

tonai avatar May 24 '22 16:05 tonai

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 14 '22 16:09 stale[bot]