SafeEyes icon indicating copy to clipboard operation
SafeEyes copied to clipboard

Change the order of the indicator implementations fallback

Open pacho2 opened this issue 2 years ago • 1 comments

Currently trayicon plugin will try to load old libappindicator implementation and, if not found, fallback to the new one:

    gi.require_version('AppIndicator3', '0.1')
    from gi.repository import AppIndicator3 as appindicator
except:
    #fall back to Ayatana
    gi.require_version('AyatanaAppIndicator3', '0.1')
    from gi.repository import AyatanaAppIndicator3 as appindicator

the problem is that, during the transition, it is common to have both installed (as they can be installed at the same time) and, then, it will keep using the old (unmaintained) version over the new one.

I would then reverse the logic to fallback to the old implementation if ayatana one is not present

Thanks a lot

pacho2 avatar Jan 20 '23 15:01 pacho2

Great it seems that you know what the fix is. If you could create a pull request and test it works for you then we can merge it.

AdamPS avatar Dec 22 '23 17:12 AdamPS

@deltragon Is this still relevant? I guess now we are only using org.kde.StatusNotifierItem

archisman-panigrahi avatar Aug 04 '24 21:08 archisman-panigrahi

Yeah, this has been fixed by #558.

deltragon avatar Aug 04 '24 22:08 deltragon