coding-standard icon indicating copy to clipboard operation
coding-standard copied to clipboard

Published 20 hours ago • verified publisher icon slevomat

Add a sniff to specify maximum number of properties per class

Open 50bhan opened this issue 4 years ago • 2 comments

Following issue #1099.

50bhan avatar Oct 22 '20 17:10 50bhan

Hi @50bhan and @kukulich,

I created a separate PR for the related sniff that limits the number of methods (instead of properties): #1214.

After that I took a look at this PR, and saw some room for minor improvements (see the individual code comments above).

Sorry for the spam. 😀

Aad

aadmathijssen avatar Apr 30 '21 20:04 aadmathijssen

@aadmathijssen Thank you for your review and good points! Agree with all of them and made the changes 👍

50bhan avatar May 01 '21 06:05 50bhan

Hi @kukulich, can you please indicate why this PR is closed? Thanks. Aad

aadmathijssen avatar Apr 11 '23 09:04 aadmathijssen