xregexp icon indicating copy to clipboard operation
xregexp copied to clipboard

Rename isBmpLast, used for Unicode data

Open slevithan opened this issue 8 years ago • 1 comments
trafficstars

In the Unicode data generators (under tools/) and Unicode addons, rename isBmpLast as the more descriptive hasOrphanHighSurrogatesAndAstral. It's only used for category C and property Any, so the long name doesn't matter.

  • Or just hasOrphanHighSurrogates and let Unicode Base know to also check whether there is astral data before flipping the order of bmp and astral data.
  • Or just hasOrphanSurrogates and let Unicode Base know to also check whether there is astral data before flipping the order. This would mean attaching this prop in more cases where it isn’t currently useful (either because there’s no astral data or there are only low surrogates), but that’s probably not so bad.

slevithan avatar Apr 17 '17 07:04 slevithan

I don't think this should be treated as a breaking change, since isBmpLast is unlikely to be used by any existing addons outside of the official XRegExp Unicode addons (which themselves barely use it).

slevithan avatar Feb 17 '18 20:02 slevithan