type-graphql-dataloader icon indicating copy to clipboard operation
type-graphql-dataloader copied to clipboard

Published 20 hours ago • verified publisher icon slaypni

upgraded to support @apollo/server 4.4.1

Open geoyws opened this issue 2 years ago • 11 comments

Do give this a try and let me know if it works! Basically we just have to change the Apollo plugin's read and write to contextValue instead of context. @slaypni @t2y Thanks so much for maintaining this gem of a library. It really saves my team a lot of time. 🙏

geoyws avatar Mar 09 '23 08:03 geoyws

@t2y @slaypni it's a breaking change for sure, perhaps we could bump the major version number and older Apollo version users can still use the older version of type-graphql-dataloader 😉. We'll have to note it in README.md as well.

geoyws avatar Apr 06 '23 08:04 geoyws

Hi @t2y @slaypni , as @geoyws mentioned, thank you for maintaining this library. It truly is a gem! I was wondering if there are any updates on the state of this PR? My team is migrating to Apollo Server v4 and incompatibility with this library is the only thing preventing us from migrating.

Would appreciate any updates. Again, thank you for the support and this PR!

RodoVJ avatar May 09 '23 16:05 RodoVJ

@RodoVJ perhaps you could fork and apply the changes on my pull request while we wait for the merge. My team has been actually going into the node_modules and applying these changes manually each time we pnpm install (if from scratch). 😅

geoyws avatar May 12 '23 02:05 geoyws

Thanks for the suggestion @geoyws 😅. We might resort to doing what your team is currently doing if we don't hear anything back soon :)

RodoVJ avatar May 15 '23 19:05 RodoVJ

image Just in case anyone wants to see where the .js code needs changing. 😬

geoyws avatar Jun 21 '23 07:06 geoyws

My sincere apologies @slaypni , I didn't run the tests after putting in this PR. I foolishly assumed changing the plugin was all that mattered. I'm going to fix all the build errors and test errors first.

geoyws avatar Jul 12 '23 04:07 geoyws

My sincere apologies @slaypni , I didn't run the tests after putting in this PR. I foolishly assumed changing the plugin was all that mattered. I'm going to fix all the build errors and test errors first.

We all are waiting for your PR! )) Thanx for u and other maintainers!

lawrentiy avatar Jul 16 '23 12:07 lawrentiy

Can we please get this merged in?

danbopes avatar Aug 21 '23 11:08 danbopes

Thank you @geoyws!

I really need this. Can we merge it? cc @slaypni @t2y

ctkc avatar Sep 13 '23 21:09 ctkc

@geoyws, thanks for your implementation of the new apollo v4 plugin. I searched and find an available npm package which can be installed by yarn add @ejekanshjain/type-graphql-dataloader.

Iran-110 avatar Dec 27 '23 05:12 Iran-110

Finally! After half a year of marathon work on my main job I finally have the time to run tests here and make sure they're passing. Sorry again everyone.

The tests are passing now so if the changes are acceptable, please consider accepting! 🙏🏼

geoyws avatar Jan 10 '24 08:01 geoyws