Slawomir Jaranowski

Results 546 comments of Slawomir Jaranowski

Please don't add node_modules to git repository

Please fix tests ... New test for new feature will be also appreciated

@Romanticoseu kindly ping

Great, thanks - code looks ok for me. Last request - please add example to README as are for other options.

> I have add example to README. Do I need to run ./update-readme.sh? Thanks. `./update-readme.sh` is used during release prepare - You need not to execute it.

First question... Do we want to have a cycles between packages and interfaces? eg: `org.apache.maven.api. Session` needs `org.apache.maven.api.services.ArtifactDeployer` and `ArtifactDeployer` needs `Session`.

👍 for merge and for release alpha

Bug is in docker-m-p - fixed in mentioned PR

@varunsh-coder Thanks for your effort, I did similar in #871

Will be appreciate show example how plugin can add new transformers like signers. I use transformers in sign-m-p for build signatures. https://github.com/s4u/sign-maven-plugin/blob/master/src/main/java/org/simplify4u/plugins/sign/ArtifactSigner40.java