Sahil Lavingia

icon indicating a website link https://sahillavingia.com/ icon indicating an email [email protected]

icon company Antiwork icon location New York, NY

Results 147 comments of Sahil Lavingia

refactor(config): update config to detect test.ts files instead of files under test dir

Please merge main to include a new caching feature!

refactor(config): update config to detect test.ts files instead of files under test dir

Would be great to merge this soon so I can use this new approach :)

refactor(config): update config to detect test.ts files instead of files under test dir

Would be great to get to this soon. If it's not done by Friday we'll have some internally do it as I think this is quite important!

fix: consider package managers the user uses when installing browsers via playwright

Merge conflicts to resolve!

fix: consider package managers the user uses when installing browsers via playwright

Failed due to not having Anthropic key, not sure why

fix: consider package managers the user uses when installing browsers via playwright

They'll be published, right? Just not included in version notes.

Fix tip position to avoid layout shift

We can start by reverting the PR is that introduced the flakiness.

Fix tip position to avoid layout shift

Don’t recommend skipping specs.

Fix tip position to avoid layout shift

We plan on updating the UX in any case, but if a simple UX improvement also fixes the flakey tests, that would be great as a middle fix

Fix tip position to avoid layout shift

Agreed with Laura. We can move forward with this direction (though may be best to wait for completion of Tailwind migration to make it easier).