ham2mon-gui icon indicating copy to clipboard operation
ham2mon-gui copied to clipboard

Expose minimum file size as a config.json option

Open masenf opened this issue 4 years ago • 1 comments

Hardcoded magic number should be a configurable option: https://github.com/slavik0329/ham2mon-gui/blob/master/server/server.js#L147

masenf avatar Sep 11 '20 20:09 masenf

It might be good to define this with 2 parameters:

  • audio quality (kbps)
  • minimum duration

Those settings would be more natural for users to configure and then it would also get away from hard coding the audio quality throughout.

I know you mentioned on your reddit thread that you're using 16 bit audio, but the default setting for ham2mon is only 8 bit. Making the audio kbps configurable in the json file would maybe serve as a hint for users that the quality is a variable.

Obviously analyzing the PCM data would be most accurate, but I would consider that overkill at this point.

masenf avatar Sep 11 '20 21:09 masenf