Sebastian Łaskawiec
Sebastian Łaskawiec
@sampsonj LGTM @abstractj Perhaps we should disable `wsl` linter? It's very picky..
Ha! It seems this is a Docker thing: ``` $ docker pull hawkular/hawkular-openshift-agent:dev Trying to pull repository docker.io/hawkular/hawkular-openshift-agent ... manifest unknown: manifest unknown ``` But the latest works fine: ```...
Thanks a lot for checking this @jmazzitelli! It seems my theory was correct. According to [Docker version history](https://docs.docker.com/docsarchive/), `17.03.1-ce` is one release ahead of `1.12.6` which is the default for...
@JunaidChaudry Could you please check my comment and rebase this PR?
@shawkins Comments addressed and this PR is ready for the next round. Highlight of the changes: - Removed the "temporary" word from the the bootstrap admin help messages - Introduced...
@shawkins The comments have been addressed and the change is ready for the next round. The major changes are in Welcome Page theme. It now doesn't print information about temporary...
Comments addressed and this PR is ready for the next round. Here's the list of changes: * Added `WelcomeResourceTest` unit test cover the most important part of the `WelcomeResource` *...
@vmuzikar @shawkins Thanks for the comments. I've pushed another update, here are the highlights: - Removed the environment variable handling in `WelcomeResource` as suggested - Unified approach with bootstrap parameters...
> Is it truly necessary for the is-temporary option to influnce the WelcomeResource? > The alternative to this static variable to map the is-temporary option to an spi key and...
@vmuzikar @shawkins I've addressed your comments and this PR should be ready for the next round of reviews.