gh4a icon indicating copy to clipboard operation
gh4a copied to clipboard

Hard-Coded bundle params + few extra strings removed #714

Open MattiaPrimavera opened this issue 6 years ago • 5 comments

Done for fragments package bundle parameters + some other hard-coded strings ;)

MattiaPrimavera avatar Sep 11 '17 00:09 MattiaPrimavera

I'd prefer if the string constants had an EXTRA_ prefix to make their usage more obvious. Also, the filter and sort strings should be moved to the Github API bindings instead.

maniac103 avatar Sep 11 '17 05:09 maniac103

Argh I though about the prefix, was not sure on your conventions ...

MattiaPrimavera avatar Sep 11 '17 07:09 MattiaPrimavera

Not sure if we follow this rule elsewhere but I think it's a good idea to keep static fields above instance fields. I saw that you placed them together in some files.

Tunous avatar Sep 11 '17 08:09 Tunous

Not sure if we follow this rule elsewhere but I think it's a good idea to keep static fields above instance fields.

:+1: If we don't do it in all places yet, we definitely should do that.

maniac103 avatar Sep 11 '17 08:09 maniac103

I've rebased this onto master, fixed mentioned issues and added similar constants to activity files.

Tunous avatar Mar 24 '18 16:03 Tunous