gh4a
gh4a copied to clipboard
Hard-Coded bundle params + few extra strings removed #714
Done for fragments package bundle parameters + some other hard-coded strings ;)
I'd prefer if the string constants had an EXTRA_
prefix to make their usage more obvious.
Also, the filter and sort strings should be moved to the Github API bindings instead.
Argh I though about the prefix, was not sure on your conventions ...
Not sure if we follow this rule elsewhere but I think it's a good idea to keep static fields above instance fields. I saw that you placed them together in some files.
Not sure if we follow this rule elsewhere but I think it's a good idea to keep static fields above instance fields.
:+1: If we don't do it in all places yet, we definitely should do that.
I've rebased this onto master, fixed mentioned issues and added similar constants to activity files.