gh4a icon indicating copy to clipboard operation
gh4a copied to clipboard

Support for github discussions

Open riedel opened this issue 1 year ago • 9 comments

New discussion entries are shown in notifications but are not clickable.

At least opening the web page would be great, however, they are not much different from issue comments.

riedel avatar Jun 30 '24 12:06 riedel

As much as I'd like to implement support for discussion notifications, the GitHub API doesn't yet provide the data we need. I sent a feature request some time ago but they haven't done anything about it yet. Feel free to upvote it to try and get their attention 🙏

Fs00 avatar Jul 07 '24 19:07 Fs00

@Fs00 would it be possible to add discussions just as a feature/tab/screen on those hubs that have them, even if not directly clickable from a notification? Or am I just stupid, but I've not found a way to see discussions from OD.

I've also seen topics that were converted from issues to discussions, where in OD they show up only up to the point of being converted, at which point they appear as if locked by a bot.

ihatemakinganaccount avatar Jul 08 '24 01:07 ihatemakinganaccount

Implementing full support for discussions in the app (like we have for issues and pull requests) is surely possible but would be a pretty big task and I personally don't have much time and motivation for doing that. A simpler addition that shouldn't take much work could be a "Discussions" shortcut in the repository "About" tab (displayed only for repos that have them) that opens the discussions page in the browser.

I've also seen topics that were converted from issues to discussions, where in OD they show up only up to the point of being converted

This is another case of the GitHub API endpoint we use not returning the data we need... 😔 The solution would be to reimplement issue/PR timeline fetching to use the newer GraphQL API, but it's a lot of work.

Fs00 avatar Jul 16 '24 09:07 Fs00

A simpler addition that shouldn't take much work could be a "Discussions" shortcut in the repository "About" tab (displayed only for repos that have them) that opens the discussions page in the browser.

That would be a perfectly valid workaround, until the API allows for full support. I'd pirsonally prefer it being opened in my browser of choice, but directly inside the app is good enough.

Cwpute avatar Jul 18 '24 05:07 Cwpute

Its long time. Any update for discussion tab?

A4alli avatar Oct 30 '24 21:10 A4alli

Its long time. Any update for discussion tab?

AFAIK this is still pending on a pending feature request in the GitHub API with no really known workaround: https://github.com/orgs/community/discussions/37536 (see above, vote there).

riedel avatar Oct 31 '24 07:10 riedel

All right. But this is a really needed feature for all. And it is definitely worth implementing.

A4alli avatar Oct 31 '24 07:10 A4alli

A quick update regarding the points that have been brought up in this issue:

  • clicking on discussion notifications now works as intended (since a few months ago, actually): GitHub has silently changed their notifications API to return the required data that makes it work
  • a "Discussions" shortcut in the repository "About" tab has been implemented in #1432, will be included in the next release
  • displaying whether an issue has been converted to a discussion in the app is still not fully doable because the GitHub API does not yet return the data we need. I have opened a feature request to GitHub here: https://github.com/orgs/community/discussions/154516, please upvote it to get their attention!

Fs00 avatar Mar 22 '25 10:03 Fs00

Upvoted the related github issue ! Here is hope this allows this feature to be available !

Cwpute avatar Mar 22 '25 11:03 Cwpute