gh4a icon indicating copy to clipboard operation
gh4a copied to clipboard

Published 20 hours ago • verified publisher icon slapperwan

Improve "Large diffs aren't rendered by default" cases

Open xabolcs opened this issue 1 year ago • 2 comments

I wasn't able to view the diff of commit a57585220f9dbd9265ad517a39961f5ac9bf75f3.

Tapped to the line stats (+2, -2) and nothing happened.

Opening the commit in browser showed that its a large diff. Are there any way to show a hint in OctoDroid?

xabolcs avatar Jul 29 '22 09:07 xabolcs

Not sure. This happens whenever the commit object returned by the API does not include the diff for the respective file. The only chance I see is checking whether there's a way to get a link to that specific file in the GH web UI, so we can open it in the browser.

maniac103 avatar Jul 29 '22 10:07 maniac103

For me a toast with a message "Large diff ..." would more than enough, no need to view those diffs in app.

I just didn't have any clue why doesn't work the new OctoDroid release. :upside_down_face: Of course, that "Large diffs ..." and a question "Would you like to open it in browser?" would be a nice improvement.

xabolcs avatar Jul 29 '22 18:07 xabolcs