gh4a icon indicating copy to clipboard operation
gh4a copied to clipboard

[Feature request] Support discussions

Open KaKi87 opened this issue 3 years ago • 15 comments

Hello,

I get notifications on OctoDroid for discussions but clicking on these won't do anything.

As a first step, it would be great if the app could redirect me to the browser after clicking it so I can see the content anyway.

Then, if possible, supporting these natively would be great.

Thanks

KaKi87 avatar Jul 28 '20 19:07 KaKi87

Are you referring to this feature?

maniac103 avatar Jul 28 '20 19:07 maniac103

It seems so, yes. I've discovered this on the vercel repo. Thanks

KaKi87 avatar Jul 28 '20 19:07 KaKi87

Any news on this ? Thanks

KaKi87 avatar Dec 31 '20 16:12 KaKi87

@maniac103

Are you referring to this feature?

I'd think it's this: https://docs.github.com/en/discussions

But it looks like there is currently only a GraphQL API for this (https://docs.github.com/en/graphql/guides/using-the-graphql-api-for-discussions)

qwerty287 avatar Jul 21 '21 12:07 qwerty287

Hello, would it be possible, at least, to not mark notifications as read when clicking on those since not openable ? Thanks

KaKi87 avatar Feb 22 '22 12:02 KaKi87

+1 I'm really surprised that there is no github client that supports discussions, why is that?

BloodRaven0 avatar Apr 12 '22 09:04 BloodRaven0

+1 Would be cool to support discussions

jedie avatar Jul 15 '22 19:07 jedie

Maybe you can add icon, add way to make this notification read, and to open link to discussion in your browser.

Norbiros avatar Aug 22 '22 06:08 Norbiros

I have a worse problem. I get notifications in the Gmail app and can't open the "view it on GitHub" links. With this app installed, I only get a toast saying "The link could not be opened: no browser was found on your device". The only way they will work is if I long press them and press "Open in Browser".

danielzgtg avatar Nov 29 '22 13:11 danielzgtg

@danielzgtg This is rather off-topic here, but is it possible that you're both on a recent Android version (11 or newer) and on an old OctoDroid version (< 4.6.7)? This kind of problem should be solved since https://github.com/slapperwan/gh4a/commit/f0c7c10825e32f0bbee8fee0b88b7e34e5b82b4c

maniac103 avatar Nov 29 '22 14:11 maniac103

@maniac103 This browser bug only occurs for discussions. I tapped "view it on GitHub" for your issue comment https://github.com/slapperwan/gh4a/issues/1008#issuecomment-1330749430 just now and it works. I am on Android 13 with OctoDroid 4.6.10 from Google Play. The specific discussion the bug occurs for is https://github.com/eslint/eslint/discussions/16557#discussioncomment-4264538.

danielzgtg avatar Nov 29 '22 16:11 danielzgtg

we are still waiting

Wjxfi avatar May 19 '23 15:05 Wjxfi

The ability to open it in browser would be nice to have. Since the discussion have sub features like polls etc, supporting it natively maybe a non trival project on itself.

zcattacz avatar May 30 '23 01:05 zcattacz

There must be an API somewhere, if giscus.app exists which uses said API.

Secret-chest avatar Jul 14 '23 15:07 Secret-chest

Hello, any news on opening discussions in browser when clicking notifications ? Thanks

KaKi87 avatar Dec 01 '23 20:12 KaKi87