Stuart Lang
Stuart Lang
Thanks @jnm2 🙂 If you add me to the team I'd be happy to approve
I agree that what Shouldly is doing here is too intrusive. From digging around and from memory, the initial problem was a bug where the stack walking within Shouldly wasn't...
I would accept a PR with a fix, we shouldn't be setting these sort of properties on consumers behalfs.
@jaredpar We've merged in a change to revert this and to handle deterministic builds differently: https://github.com/shouldly/shouldly/pull/883 (your opinion and review is welcome) Shouldly has provided a `CallerArgumentExpression` like feature that...
My availability tends to be patchy, but I'd like to stay active. I don't contribute to a level that would warrant mention in the README however 😄
I think there's value in this, and it's safe as you've explained.
It might be worth converting to value tuple in these cases, even if it's at the last moment like this: ```csharp _tuple.ToValueTuple().ShouldBe(("x", "y"), "message"); ``` This isn't to say a...
The guid matches the `service.instance.id` for the container
Playing around here, I've managed to find the offending code, so this only happens when I specify a service name and/or version like this: ```csharp .WithTracing((builder) => { builder.SetResourceBuilder(ResourceBuilder.CreateDefault().AddService(ApplicationTelemetry.ServiceName)) //...
This was really hard to replicate, but I finally got it 😅 It only happens when the Aspire resource name matches the service name, then the Aspire dashboard starts displaying...