slang icon indicating copy to clipboard operation
slang copied to clipboard

option to specify csvSettingsDetector

Open deadsoul44 opened this issue 2 years ago • 4 comments

Motivation I am using a different text delimiter. Slang cannot parse my csv.

Developer Experience There should be an option to specify csvSettingsDetector.

var d = new FirstOccurrenceSettingsDetector(eols: ['\r\n', '\n'], textDelimiters: ['"', "'"]);
new CsvToListConverter(csvSettingsDetector: d);

deadsoul44 avatar Nov 22 '22 07:11 deadsoul44

Thanks for this issue!

I think that your solution is good enough to be default as it supports both CRLF and LF, " and '.

Released in v3.5.0.

Tienisto avatar Nov 24 '22 01:11 Tienisto

Actually, I use a different delimiter and wanted to specify it as a parameter. I checked the changelog, docs, tests and couldn’t see that kind of parameter. I guess you added the above as builtin default values.

deadsoul44 avatar Nov 24 '22 11:11 deadsoul44

Alright, sorry. Yep, this is now default. I guess this parameter is missing in the config file.

Tienisto avatar Nov 24 '22 11:11 Tienisto

Friendly reminder :) This is the only blocking issue to switch from another localization package.

deadsoul44 avatar May 16 '23 10:05 deadsoul44