wpfolio icon indicating copy to clipboard operation
wpfolio copied to clipboard

border-top for div. footer

Open dimatosj opened this issue 14 years ago • 5 comments

a line appears to disconnect the content from the footer. what's happening is that in the optional-stylesheet.php div .footer is set to grab the overall background color now set in wordpress instead of the color of the container. here's the switch I made:

in optional-stylesheet.php

replaced

border-top: solid 1px #;

with

border-top: solid 1px #;

(didn't seem to want to take from the child theme, so had to make the mod straight into wpfolio/library/optional-stylesheet.php)

dimatosj avatar Feb 25 '11 20:02 dimatosj

Hm, you can't do this in the child theme?

border-top: none;

slambert avatar Feb 25 '11 21:02 slambert

I thought that would resolve it too - but it seems optional-stylesheet overrides, since this addition to child-theme shows up crossed out in firebug.

div.footer { border-top: none; }

dimatosj avatar Feb 25 '11 21:02 dimatosj

I also tried adding a modded optional-stylesheet.php to the child theme, as well as the full function where that div css is created in functions.php in the child. Modding the regular theme didn't feel right...

dimatosj avatar Feb 25 '11 21:02 dimatosj

Smart thinking....

The line in the design was my idea but I understand the desire for an option and it shouldn't be as difficult as it is to change.

We're about to submit another release soon. If you want to create an option for this, I'll include it, but I can't code it myself right now.

slambert avatar Feb 25 '11 22:02 slambert

I just looked at changing the order these appear in the header:

The stylesheet for theme is called before the options stylesheet.

If it's a child theme, the style link should appear below the options styslesheet, because the child theme should trump all.

But if it's not a child theme, the options theme must override the default stylesheet and appear below.

So flipping the order wont work. This has to be done through some kind of theme option.

slambert avatar Apr 12 '11 17:04 slambert