pydm
pydm copied to clipboard
slaclab
Remove PYDM from the start of each widget in designer
Currently all PYDM widget names in designer begin with "PYDM" which makes it harder to scan for the desired widget. Below is a mockup of what I request.
Currently
Request
This is smart, we should do this. My only concern is if there's some name collision between a native Qt widget and the PyDM version of that same widget. I don't know how designer handles that. If there's a problem, we might need to use something like "Slider (PyDM)" for the PyDM version.
If we do implement this, I suggest maintaining PyDM in the widget name somewhere. I often filter the widget list, and it would be confusing if the list just displays two widgets of the 'same' name. We'd lose the information that says these widgets do different things.
Ex.
.
I think the easiest solution is to have PYDM appended to the widget name instead of prepended That way we don’t have to worry about name conflicts but get the benefit of being able to skim the list.
On Sep 28, 2021, at 13:44, kabanaty @.***> wrote:
If we do implement this, I suggest maintaining PyDM in the widget name somewhere. I often filter the widget list, and it would be confusing if the list just displays two widgets of the 'same' name. We'd lose the information that says these widgets do different things. Ex.
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.
I'm going to make the case for leaving it as is, even though it is a bit hard to scan in a hurry (I've personally gotten used to it, or like Tyler I use the filter).
If the widget name was changed, all the widgets used in files made at SLAC and elsewhere would have to be updated. And since we would have to replace it with something that also included 'pydm' to distinguish it from the standard PyQt widgets there's no real gain.
If only the widget name/label in Designer was changed, but not the actual widget name, I think this could lead to confusion if there's inconsistency when people switch between graphically building the UI files and coding the interface with Python.
Either way, I would want to make sure there was wide agreement in this before going ahead with any change.
