nebula icon indicating copy to clipboard operation
nebula copied to clipboard
verified publisher icon slackhq

SIGHUP does not trigger reload of stats config

Open adamrothman opened this issue 6 years ago • 2 comments

Sending a SIGHUP to Nebula reloads most settings, but this functionality notably excludes the stats emitter.

https://github.com/slackhq/nebula/blob/065e2ff88a9ae1531833e8bae2665761ec0dd102/main.go#L313

https://github.com/slackhq/nebula/blob/065e2ff88a9ae1531833e8bae2665761ec0dd102/interface.go#L159-L164

It would be awesome if a reload could also take care of the stats emitter.

adamrothman avatar Feb 20 '20 22:02 adamrothman

https://github.com/slackhq/nebula/blob/befce3f9903f8772a3282c4dcc6bb36c5d202cc9/main.go#L395-L397

the linked comment makes me think that the dependent stats modules need to be changed so that they can be stopped and restarted w/ the new config info?

jasikpark avatar May 27 '22 18:05 jasikpark

The comment was added in https://github.com/slackhq/nebula/pull/550/files#diff-2873f79a86c0d8b3335cd7731b0ecf7dd4301eb19a82ef7a1cba7589b5252261 for context

jasikpark avatar May 27 '22 18:05 jasikpark