nebula icon indicating copy to clipboard operation
nebula copied to clipboard

make boringcrypto: add checklinkname flag for go1.23

Open wadey opened this issue 1 year ago • 0 comments

Starting with go1.23, we need to set -checklinkname=0 when building for boringcrypto because we need to use go:linkname to access newGCMTLS.

Note that this does break builds when using a go version less than go1.23.0. We can probably assume that someone using this Makefile and manually building is using the latest release of Go though.

See:

  • https://go.dev/doc/go1.23#linker

Without this change on go1.23+, you will see an error like this:

# github.com/slackhq/nebula/cmd/nebula
link: github.com/slackhq/nebula/noiseutil: invalid reference to crypto/internal/boring.NewGCMTLS

wadey avatar Aug 13 '24 17:08 wadey