nebula icon indicating copy to clipboard operation
nebula copied to clipboard

Bump gvisor to v0.0.0-20240313225113-67a078058255, fix service

Open JackDoan opened this issue 5 months ago • 6 comments

gvisor and the service example didn't build for me on go 1.22, this fixes that.

JackDoan avatar Mar 14 '24 19:03 JackDoan

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Jack Doan <j***@r***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

salesforce-cla[bot] avatar Mar 14 '24 19:03 salesforce-cla[bot]

Thanks for the contribution! Before we can merge this, we need @JackDoan to sign the Salesforce Inc. Contributor License Agreement.

salesforce-cla[bot] avatar Mar 14 '24 19:03 salesforce-cla[bot]

Thanks! I might need to combine these changes with #981 to get the tests to pass for merging. Looking into it now.

(the tests seem to fail with note: module requires Go 1.21)

wadey avatar Apr 23 '24 19:04 wadey

merging your branch into #981 (so your branch + go1.22) still seems to be getting some weird failures:

# gvisor.dev/gvisor/pkg/waiter
Error: ../../../go/pkg/mod/gvisor.dev/[email protected]/pkg/waiter/waiter.go:140:2: undefined: waiterEntry
Error: ../../../go/pkg/mod/gvisor.dev/[email protected]/pkg/waiter/waiter.go:211:7: undefined: waiterList
FAIL	github.com/slackhq/nebula/examples/go_service [build failed]

wadey avatar Apr 23 '24 20:04 wadey

oh I see, Github Actions is still selecting the wrong go version. I thought we had it configured to use the version in go.mod.

The other issue is that we need to do go get gvisor.dev/gvisor@go to get the latest version from the go branch, see their docs.

wadey avatar Apr 23 '24 20:04 wadey

I have the tests passing in #981 by merging in your changes and making a few more fixes. I'll make sure to credit you in the merge commit there. Thanks!

wadey avatar Apr 24 '24 00:04 wadey

Closing as superseded by #981. Thank you!

johnmaguire avatar Apr 29 '24 23:04 johnmaguire