goSDL icon indicating copy to clipboard operation
goSDL copied to clipboard

check http status code

Open jasonmacgowan opened this issue 6 years ago • 3 comments

Summary

throws errors on http status codes >=400 so the user knows the expected action failed

fixes (kinda) #16

Requirements (place an x in each [ ])

The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)

  • [x] I've written tests to cover the new code and functionality included in this PR.

The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io

jasonmacgowan avatar Sep 12 '18 19:09 jasonmacgowan

This is a start but really we should be more verbose about what actually failed

Also it's possible to do this by setting something like the following" curl_setopt($ch,CURLOPT_FAILONERROR,true);

Maybe that's the default for some people and they weren't encountering this?

jasonmacgowan avatar Sep 12 '18 19:09 jasonmacgowan

Hi, thanks for looking at this. Are you able to visit the following URL to sign the CLA? https://cla-assistant.io/slackhq/goSDL?pullRequest=17

fyunaz avatar Dec 19 '18 19:12 fyunaz

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 30 '19 01:07 CLAassistant