goSDL
goSDL copied to clipboard
check http status code
Summary
throws errors on http status codes >=400 so the user knows the expected action failed
fixes (kinda) #16
Requirements (place an x
in each [ ]
)
- [x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
- [x] I've read and agree to the Code of Conduct.
The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)
- [x] I've written tests to cover the new code and functionality included in this PR.
The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io
- [ ] I've read, agree to, and signed the Contributor License Agreement (CLA).
This is a start but really we should be more verbose about what actually failed
Also it's possible to do this by setting something like the following" curl_setopt($ch,CURLOPT_FAILONERROR,true);
Maybe that's the default for some people and they weren't encountering this?
Hi, thanks for looking at this. Are you able to visit the following URL to sign the CLA? https://cla-assistant.io/slackhq/goSDL?pullRequest=17
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.