go-audit
go-audit copied to clipboard
Add ability to skip applying rules
- [x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
- [x] I've read and agree to the Code of Conduct.
- [x] I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
- [x] I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
- [x] I've written tests to cover the new code and functionality included in this PR.
- [x] I've read, agree to, and signed the Contributor License Agreement (CLA).
PR Summary
This introduces a skip_rules
configuration setting which prevents go-audit from setting rules itself. This enables audit rules to be set by an external system, utilizing go-audit exclusively for logging.
Codecov Report
Merging #61 into master will decrease coverage by
0.1%
. The diff coverage is25%
.
@@ Coverage Diff @@
## master #61 +/- ##
=========================================
- Coverage 75.21% 75.1% -0.11%
=========================================
Files 5 5
Lines 476 478 +2
=========================================
+ Hits 358 359 +1
- Misses 101 102 +1
Partials 17 17
Impacted Files | Coverage Δ | |
---|---|---|
audit.go | 74.68% <25%> (-0.21%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update daf7385...ad94b32. Read the comment docs.
Is anyone checking these?
:wave: @davidhuie-dd thanks for the PR! This looks like a good idea to me but I'd like to modify it a bit. rules.skip
seems more natural, can you also update the example config with a little comment about the additional option?