SlackTextViewController
SlackTextViewController copied to clipboard
Provide a warning to implementor when container view has mismatched configuration
Embedding SLKTextViewController
in a container view will most likely cause an incorrect bottom margin calculation. Especially when storyboarding as https://github.com/slackhq/SlackTextViewController/issues/668
- [X] I've read and understood the Contributing guidelines and have done my best effort to follow them.
- [X] I've read and agree to the Code of Conduct.
- [X] I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
- [X] I've added a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
- [X] I've listed my changes on the [Changelog(https://github.com/slackhq/SlackTextViewController/blob/master/CHANGELOG.md) file.
- [X] I've read, agree to, and signed the Contributor License Agreement (CLA).
PR Summary
Scream at user if there is a tabbar inside a container view and its configuration differs from its parent.
Related Issues
Fixes for #668 and #680
Test strategy
NOOP, adds a console warning to potentially reduce headaches. This could and probably be branched, as it's almost never what the implementor intended. Or simply could take the parentViewController's properties when not null (meaning it's in a container). When storyboarding and running, the tabbar isn't shown, and respects the parent's setting, but SlackTextViewController
reads this property on the container and provides an incorrect margin making this very difficult to track down and debug.