SlackTextViewController icon indicating copy to clipboard operation
SlackTextViewController copied to clipboard

Increase SLKTextView's influence over calculating its height.

Open lukkas opened this issue 6 years ago • 0 comments

  • [x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • [x] I've read and agree to the Code of Conduct.
  • [x] I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • [x] I've added a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • [x] I've listed my changes on the [Changelog(https://github.com/slackhq/SlackTextViewController/blob/master/CHANGELOG.md) file.
  • [x] I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

Change doesn't affect the functionality in any way. It moves SLKTextView height calculation logic to SLKTextView class itself. This adds flexibility when subclassing SLKTextView. Example: When adding custom line spacing using NSAttributedString and NSParagraphStyle to text in text view, there is currently no way to change its height in order to accommodate text formatted that way.

lukkas avatar Nov 16 '17 15:11 lukkas