SlackTextViewController
SlackTextViewController copied to clipboard
Fixed placeholder label layout - it should calculate bounds considering label width, not bounds width
- [ ] I've read and understood the Contributing guidelines and have done my best effort to follow them.
- [ ] I've read and agree to the Code of Conduct.
- [ ] I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
- [ ] I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
- [ ] I've written tests to cover the new code and functionality included in this PR.
- [ ] I've read, agree to, and signed the Contributor License Agreement (CLA).
PR Summary
Fixed placeholder label layout - it should calculate bounds considering label width, not bounds width
@akievsk did you find any ways to reproduce the issue on the sample project? I haven't experienced any issues with the label. Even tho your changes seem logical, I would first want to verify the fix.
Here is the sample how this bug can be reproduced. I changed placeholder to something "very long" and changed height of text view to be more than one line
Great. This is useful, thanks. Will review this soon.