SlackTextViewController icon indicating copy to clipboard operation
SlackTextViewController copied to clipboard

Bottom margin on iOS 10.

Open cbedoy opened this issue 9 years ago • 11 comments

  • [x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • [x] I've read and agree to the Code of Conduct.
  • [x] I've searched for any related issues and avoided creating a duplicate issue.

Description

Runs the project with iOS 10.0

Reproducible in:

  • [x] This is reproducible in the sample project. iOS version(s): 10.0 Device(s): iPhone 6S plus

Hi everyone I would like know if you are already working with support iOS 10, we're using your library into our project, but we detected that we have a bottom margin on the ChatView, also it's showing into your example project. I know that it's really new, but I would like know.

Any fast solution ?

14374580_10210217936542674_1385732762_o

it looks like the margin is the same size of input bar

cbedoy avatar Sep 16 '16 04:09 cbedoy

What version of the library are you using? Also, are you using the inverted mode?

PS: Nice looking chat app btw!

dzenbot avatar Oct 04 '16 01:10 dzenbot

Hi!

I'm using 1.9.4 version, with inverted mode.

I just see that you have a new release.

Notice: When the keyboard is showing and dismiss the bottom margin fixed

cbedoy avatar Oct 04 '16 04:10 cbedoy

It would be helpful if you could repro this on the sample project.

dzenbot avatar Oct 04 '16 04:10 dzenbot

Hi, I have the same issue. iOS 10, 1.9.4 version, inverted mode. You just need to change tableview cell to a custom class. There is a bottom margin until you bring up the keyboard first time.

jderes avatar Oct 12 '16 12:10 jderes

@jderes @dzenbot

I solved added the next lines on your viewWilAppear

[self setAutomaticallyAdjustsScrollViewInsets:NO]; [[self tableView] setContentInset:UIEdgeInsetsZero];

cbedoy avatar Oct 17 '16 05:10 cbedoy

@cbedoy Thanks for your solution! Just setting automaticallyAdjustsScrollViewInsets = false in viewWillAppear in my SLKTextViewController subclass fixed this for me. I didn't need to reset the content inset as well.

soleares avatar Oct 18 '16 18:10 soleares

I sent a pull request with that fixed on

https://github.com/slackhq/SlackTextViewController/pull/531

cbedoy avatar Oct 18 '16 18:10 cbedoy

Thanks @cbedoy! Will have a look very soon.

dzenbot avatar Oct 18 '16 20:10 dzenbot

Hey, I just wanted to say that this was also happening to me, and automaticallyAdjustsScrollViewInsets = false did fix it for me too.

NinoScript avatar Feb 13 '17 16:02 NinoScript

yep did the trick for me as well..

yarodevuci avatar Feb 20 '17 11:02 yarodevuci

https://github.com/slackhq/SlackTextViewController/pull/531

cbedoy avatar Feb 20 '17 18:02 cbedoy