PanModal icon indicating copy to clipboard operation
PanModal copied to clipboard
verified publisher icon slackhq

Issues with autofill in custom fork (posted in SO)

Open mgray88 opened this issue 5 years ago • 2 comments

Description

https://stackoverflow.com/questions/60675224/ios-13-autofill-not-filling-uitextfield-until-user-manually-focuses-it I realize this may be out of the bounds of this project, but I was hoping to draw more attention to an issue I posted on StackOverflow. I noticed there were a few issues about keyboards with text fields, but this goes a bit beyond that. I have that part working (sure it's not perfect), but Password Autofill on iOS 13 refuses to fill in the selected credentials until the user manually reselects the text field

What type of issue is this? (place an x in one of the [ ])

  • [x] bug
  • [ ] enhancement (feature request)
  • [ ] question
  • [ ] documentation related
  • [ ] testing related
  • [ ] discussion

Requirements (place an x in each of the [ ])

  • [x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • [x] I've read and agree to the Code of Conduct.
  • [x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

PanModal version: 1.2.6 -> https://github.com/mgray88/PanModal/tree/toc.1

iOS version: 13.3

Steps to reproduce:

  1. Noted in SO post

Attachments:

Sample project showing issue: https://github.com/mgray88/AutofillTest

mgray88 avatar Mar 13 '20 18:03 mgray88

Hi @mgray88

Thanks for reporting. Do you have a video of this interaction?

From the sounds of it, the issue may not be related to PanModal and may be a bug with custom transitions & the native iOS keyboard. The library does not interfere with touch, the firstResponder or native auto-fill.

Stephen

ste57 avatar Mar 25 '20 00:03 ste57

video: https://drive.google.com/open?id=1JpPe01BE-Hk3MTNmgUrix-fhvAFz3WIL

It's probably something related to the code I added/modified, but I noticed in #23 you mentioned working with keyboard, so I was hoping you might have some insight

Edit, FWIW: I added back in the begin and endAppearanceTransition calls to the presenting view controller, as that seemed like it might be the only thing causing an issue, to no effect. Everything else I added is pretty much just visual sugar

mgray88 avatar Mar 25 '20 19:03 mgray88