PanModal icon indicating copy to clipboard operation
PanModal copied to clipboard
verified publisher icon slackhq

Fix ios 17.1+ issue

Open oscarcv opened this issue 2 years ago • 6 comments

Summary

Fix for ios 17.1+ versions when displaying certain UIViewControllers where containerView has not yet been set.

Requirements (place an x in each [ ])

  • [x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.

  • [x] I've read and agree to the Code of Conduct.

  • [x] I've written tests to cover the new code and functionality included in this PR.

oscarcv avatar Nov 03 '23 16:11 oscarcv

@TosinAF @ste57 Could any of you take a look at this small change to support iOS 17.1 and above? The fix is for this issue https://github.com/slackhq/PanModal/issues/202

Pato-Salazar avatar Nov 03 '23 17:11 Pato-Salazar

I don't think I have access to approve pull requests on this repo anymore - I may create a personal fork if this is causing frequent issues

ste57 avatar Nov 03 '23 18:11 ste57

That could be cool. I think this is causing frequent issues.

Pato-Salazar avatar Nov 03 '23 19:11 Pato-Salazar

@oscarcv

The code doesn't work on iPad, do you know the reason?

kwontaewan avatar Nov 06 '23 04:11 kwontaewan

@oscarcv

The code doesn't work on iPad, do you know the reason?

I have only tested it on iPhone. If you can make a basic project where the problem is reproduced I try to fix

oscarcv avatar Nov 06 '23 05:11 oscarcv

does anybody find solution for iPad?

springfk avatar Dec 13 '23 07:12 springfk