PanModal icon indicating copy to clipboard operation
PanModal copied to clipboard

Add delegate to check if pan gesture should begin

Open damienvieira opened this issue 3 years ago • 2 comments

Summary

This change allows to control if the pan gesture should begin or not. This is particularly important when your table view supports drag and drop or swipe to delete, since the pan gesture will conflict with the other table view gestures/touches.

The current delegate function func shouldRespond(to panModalGestureRecognizer: UIPanGestureRecognizer) -> Bool it is not enough to manage the pan gesture, because it's called too late during the gesture handling process.

Related issue/question: https://github.com/slackhq/PanModal/issues/82

Requirements (place an x in each [ ])

  • [x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.

  • [x] I've read and agree to the Code of Conduct.

  • [ ] I've written tests to cover the new code and functionality included in this PR.

damienvieira avatar Feb 02 '21 16:02 damienvieira

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Damien Vieira seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 02 '21 16:02 CLAassistant

@damienvieira would you mind signing the CLA when you have a chance?

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.

Roach avatar Feb 19 '21 00:02 Roach