PanModal icon indicating copy to clipboard operation
PanModal copied to clipboard

Add ability to choose background interaction mode (.dismiss / .forward or .none)

Open ilia3546 opened this issue 3 years ago • 7 comments

Summary

Related issue - #100

Now you can choose one of background interaction modes:

  • .dismiss - Taps dismiss the modal immediately
  • .forward - Touches are forwarded to the lower window (In most cases it would be the application main window that will handle it
  • .none - Absorbs touches. The modal does nothing (Swallows the touch)

Example:

class MyPanModal: UIViewController, PanModalPresentable {

    ...

    var backgroundInteraction: PanModalBackgroundInteraction {
        return .forward
    }

}

I think now option allowsTapToDismiss can be marked as deprecated.

Requirements (place an x in each [ ])

  • [x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.

  • [x] I've read and agree to the Code of Conduct.

  • [x] I've written tests to cover the new code and functionality included in this PR.

ilia3546 avatar Aug 19 '20 13:08 ilia3546

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: ilia3546
:x: Ilya Kharlamov


Ilya Kharlamov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 19 '20 13:08 CLAassistant

I really look forward to have this functionality!

devxoul avatar Nov 02 '20 19:11 devxoul

Please, could someone with write access review this PR? I have stopped using this library because of this issue. @jordanpichler @ste57 @TosinAF @Marcocanc

a777med avatar Dec 07 '20 11:12 a777med

Sadly I don't have write access to approve this PR.

@a777med you can always point your dependency manager (Cocoapods or Swift Package Manager) to @ilia3546 branch to include this PR. No need to wait for Slack to create a release with this PR 😉

jordanpichler avatar Dec 07 '20 14:12 jordanpichler

Hi guys, it's been a while not have any update on this PR.

Do we have a plan to merge it?

lhr000lhrmega avatar Feb 24 '21 23:02 lhr000lhrmega

Works really well! 💯 Hope it gets merged soon

ivopintodasilva avatar Mar 11 '21 17:03 ivopintodasilva