PanModal icon indicating copy to clipboard operation
PanModal copied to clipboard

Support iOS 9 target

Open owdax opened this issue 5 years ago • 5 comments

Summary

Added Support for iOS 9 target (for projects that have min iOS 9 target and can't use PanModal)

Requirements (place an x in each [ ])

  • [x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.

  • [x] I've read and agree to the Code of Conduct.

  • [ ] I've written tests to cover the new code and functionality included in this PR.

owdax avatar Jul 11 '20 21:07 owdax

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 11 '20 21:07 CLAassistant

it will be nice if we can get a clarification from the owner of the this Library, whether the support for ios 9 will be taken into the consideration or not. We also need to use this library as well need to support ios 9 in our App, so please give us some sign that we can able to use this library directly from the main repo. Thanks

sumitsumanclip avatar Jul 28 '20 18:07 sumitsumanclip

@ste57 Could you please review this PR, thanks

owdax avatar Jul 28 '20 18:07 owdax

Hi @omiddlk

I'd recommend merging this on a fork as we're not looking to support iOS 9 publicly

ste57 avatar Jul 28 '20 20:07 ste57

Hi @omiddlk will you be making a fork ? please mention me in your PR if you make it. Thanks

sumitsumanclip avatar Jul 29 '20 15:07 sumitsumanclip