slack-github-action icon indicating copy to clipboard operation
slack-github-action copied to clipboard

Action fails silently if SLACK_BOT_TOKEN is not set

Open gr2m opened this issue 4 years ago • 1 comments

Description

Action fails silently if SLACK_BOT_TOKEN is not set

What type of issue is this? (place an x in one of the [ ])

  • [x] bug
  • [ ] enhancement (feature request)
  • [ ] question
  • [ ] documentation related
  • [ ] example code related
  • [ ] testing related
  • [ ] discussion

Requirements (place an x in each of the [ ])

  • [x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • [x] I've read and agree to the Code of Conduct.
  • [x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

package version: 1.15.0

node version: I don't think you should ask that, as it's configured in your own action.yml

OS version(s): ubuntu-latest

Steps to reproduce:

        env:
          SLACK_BOT_TOKEN: ${{ secrets.DOES_NOT_EXIST }}

Expected result:

Should error with a helpful message

Actual result:

No output, success status

Attachments:

image

gr2m avatar Aug 22 '21 17:08 gr2m

Thanks again. As with https://github.com/slackapi/slack-github-action/issues/9, the error can be improved by having some validation as part of the action.

seratch avatar Nov 07 '21 22:11 seratch