python-slack-sdk icon indicating copy to clipboard operation
python-slack-sdk copied to clipboard

Add is_send_allowed to assistant.threads.setStatus arguments

Open seratch opened this issue 1 year ago • 2 comments

Summary

This pull request adds a new argument to https://api.slack.com/methods/assistant.threads.setStatus

Category

  • [x] slack_sdk.web.WebClient (sync/async) (Web API client)
  • [ ] slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • [ ] slack_sdk.socket_mode (Socket Mode client)
  • [ ] slack_sdk.signature (Request Signature Verifier)
  • [ ] slack_sdk.oauth (OAuth Flow Utilities)
  • [ ] slack_sdk.models (UI component builders)
  • [ ] slack_sdk.scim (SCIM API client)
  • [ ] slack_sdk.audit_logs (Audit Logs API client)
  • [ ] slack_sdk.rtm_v2 (RTM client)
  • [ ] /docs (Documents)
  • [ ] /tutorial (PythOnBoardingBot tutorial)
  • [ ] tests/integration_tests (Automated tests for this library)

Requirements

  • [x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • [x] I've read and agree to the Code of Conduct.
  • [x] I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

seratch avatar Oct 28 '24 00:10 seratch

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 84.90%. Comparing base (5c8f595) to head (deee223). :warning: Report is 110 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1577      +/-   ##
==========================================
+ Coverage   84.87%   84.90%   +0.03%     
==========================================
  Files         113      113              
  Lines       12599    12599              
==========================================
+ Hits        10693    10697       +4     
+ Misses       1906     1902       -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 28 '24 00:10 codecov[bot]

Converted this PR to draft state; We will hold off merging it untill the server is ready

seratch avatar Oct 28 '24 22:10 seratch

👋 I find this parameter interesting myself, but I don't think we have immediate plans to support it so I'll close this much appreciated PR.

For the meantime I can share notes from our latest release!

📚 https://github.com/slackapi/python-slack-sdk/releases/tag/v3.37.0

zimeg avatar Oct 08 '25 01:10 zimeg