node-slack-sdk icon indicating copy to clipboard operation
node-slack-sdk copied to clipboard

Do not merge: Add support for entity metadata

Open vegeris opened this issue 9 months ago • 1 comments

Summary

Describe the goal of this PR. Mention any related Issue numbers.

Requirements (place an x in each [ ])

vegeris avatar Apr 09 '25 23:04 vegeris

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 93.02%. Comparing base (16bd88e) to head (3ae9720). :warning: Report is 1 commits behind head on main. :white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2231   +/-   ##
=======================================
  Coverage   93.01%   93.02%           
=======================================
  Files          40       40           
  Lines       11111    11124   +13     
  Branches      713      713           
=======================================
+ Hits        10335    10348   +13     
  Misses        764      764           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 94.79% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 61.87% <ø> (ø)
web-api 98.08% <100.00%> (+<0.01%) :arrow_up:
webhook 96.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 10 '25 01:04 codecov[bot]

I'm not sure what's going on with the failing tests in the cli-test package;

 Exception during run: src/cli/shell.spec.ts(21,55): error TS2345: Argument of type 'SpawnSyncReturns<Buffer<ArrayBufferLike>>' is not assignable to parameter of type 'SpawnSyncReturns<string | NonSharedBuffer>'.
...

It seems like the object being passed in matches the interface

    runOutput = { pid: 1337, output: [], stdout: Buffer.from("[]"), stderr: Buffer.from("[]"), status: 0, signal: null };
    runSpy = sandbox.stub(child, 'spawnSync').returns(runOutput);

Edit: resolved!

vegeris avatar Oct 22 '25 16:10 vegeris