java-slack-sdk icon indicating copy to clipboard operation
java-slack-sdk copied to clipboard

Java 9+ Modularity Supports

Open denismakogon opened this issue 5 years ago • 7 comments

trying out a simple slack API within a module, but seeing this problem

Error: Modules jslack.api.client and jslack.api.model export package com.github.seratch.jslack.common.json to module okio

it doesn't seem like jslack was ever adjusted to work with Project Jigsaw (java 9 modules).

denismakogon avatar Aug 08 '19 09:08 denismakogon

Thank you for your feedback. Honestly, I'm not familiar with making libraries compatible with Java modules yet but I'd love to make jslack modules-ready. Could you help me?

seratch avatar Aug 08 '19 10:08 seratch

I revisited this issue a little bit but let me hold working on this. I would like to continue supporting Java 8 for a while.

seratch avatar Sep 12 '19 12:09 seratch

@seratch I'd be happy to submit a pull request to fix this, while still maintaining Java 8 compatibility.

jhg023 avatar Sep 24 '19 01:09 jhg023

That is really needed thing, we unable to use in the project slack-api-client together with slack-api-model in project due to lack of modularity support [ERROR] module <our-module> reads package com.slack.api.meta from both slack.api.client and slack.api.model

tvladyka-photobox avatar Nov 02 '21 15:11 tvladyka-photobox

Tricky thing to make slack API compatible with Java Module system:

  • Same "public" packages are present in 2 jars: "com.slack.api.meta" and "com.slack.api.util.json"
  • slack-api-model uses internal class from Google GSON dependency (as workaround for a bug)

sebastien-lamps avatar Nov 11 '21 09:11 sebastien-lamps

Dear Slack Devs, what is the state of this issue? It still produces error in module-info.java when using your client lib. When do you plan to fix this? Thx Benjamin

grafik grafik

bsalture avatar Jan 03 '24 15:01 bsalture