java-slack-sdk icon indicating copy to clipboard operation
java-slack-sdk copied to clipboard

create undocumented message bot events

Open bruceadowns opened this issue 11 months ago • 4 comments

  • create undocumented message bot events
  • message_bot_add
  • message_bot_remove
  • these occur on add/remove of incoming webhook

Category (place an x in each of the [ ])

  • [x] bolt (Bolt for Java)
  • [ ] bolt-{sub modules} (Bolt for Java - optional modules)
  • [x] slack-api-client (Slack API Clients)
  • [ ] slack-api-model (Slack API Data Models)
  • [ ] slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • [ ] slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

bruceadowns avatar Jan 22 '25 15:01 bruceadowns

@seratch I would like to add these 2 events to my bot, would you pls review. Also, I suspect you may want unit tests, if so pls give me an overview of what tests you’d like to see, and where they go.

bruceadowns avatar Jan 25 '25 17:01 bruceadowns

Thanks for taking the time to send this pull request. Let me mention two points:

  • It seems these two subtypes may actually exist but it's not officially listed in the document yet; so at this moment, we're unable to add these changes to SDKs. Our team is communicating with relevant teams on this, so once it's available in the public documents, we can consider adding these classes to this SDK
  • This pull request includes extra changes that are not related to the message event class addition; some of the extra changes seem to be beneficial for this SDK's quality. If you're fine to spend more time, could you revert those changes in this PR and make a different PR for them? We can review it separately

seratch avatar Feb 03 '25 07:02 seratch

Thank you @seratch, I reverted unrelated changes. I will mark this PR as ready and then wait until your team gets official word. Tests can be added at that time if you choose to go forward.

bruceadowns avatar Feb 03 '25 17:02 bruceadowns

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.15%. Comparing base (f936ad2) to head (181e3de). Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1424      +/-   ##
============================================
- Coverage     73.20%   73.15%   -0.06%     
+ Complexity     4388     4387       -1     
============================================
  Files           475      475              
  Lines         14243    14243              
  Branches       1447     1447              
============================================
- Hits          10427    10419       -8     
- Misses         2959     2970      +11     
+ Partials        857      854       -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 04 '25 04:02 codecov[bot]