deno-slack-api icon indicating copy to clipboard operation
deno-slack-api copied to clipboard

Add `files.uploadV2`

Open filmaj opened this issue 1 year ago • 8 comments

⚠️ WIP!

This PR supersedes #90 and fixes #89. It builds upon previous work done by @taiga533; I intend to get it over the finish line.

TODO

  • [ ] Get full list of requested changes from #90 and add to this list!

filmaj avatar Aug 27 '24 21:08 filmaj

Thanks for the contribution! Before we can merge this, we need @racTaiga533 to sign the Salesforce Inc. Contributor License Agreement.

salesforce-cla[bot] avatar Aug 27 '24 21:08 salesforce-cla[bot]

Confirmed that we have a CLA on file for @racTaiga533 (signed 2023/12/15) - can ignore the CLA bot's complaints.

filmaj avatar Aug 27 '24 21:08 filmaj

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f7915fb) to head (af50137).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #111   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         1133      1196   +63     
  Branches        17        27   +10     
=========================================
+ Hits          1133      1196   +63     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 27 '24 21:08 codecov[bot]

What's the status on this PR? I need this functionality, it would be nice if it was merged and deployed. @WilliamBergamin @filmaj

deefactorial avatar Oct 06 '24 23:10 deefactorial

Screenshot 2024-11-07 at 11 28 11 AM still not working, is there any way I can use this PR temporarily until it's merged?

deefactorial avatar Nov 07 '24 19:11 deefactorial

The code provided does work but I'd probably change the API a bit. Is this moving forward? Shall/May I take over?

simhnna avatar Dec 04 '24 16:12 simhnna

bump this would seem to have some urgency since the files.upload API will stop functioning on March 11, 2025, less than one week away!

lynfos avatar Mar 05 '25 04:03 lynfos

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Filip Maj <f***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

salesforce-cla[bot] avatar Mar 05 '25 17:03 salesforce-cla[bot]