deno-slack-api icon indicating copy to clipboard operation
deno-slack-api copied to clipboard

add JSR support

Open lambtron opened this issue 1 year ago • 2 comments

Summary

This PR includes the necessary import update to publish to JSR

Special notes

Let's discuss in Slack.

Requirements

  • [x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • [x] I've read and agree to the Code of Conduct.
  • [x] I've ran deno task test after making the changes.

lambtron avatar Aug 12 '24 17:08 lambtron

Thanks for the contribution! Before we can merge this, we need @lambtron @iuioiua to sign the Salesforce Inc. Contributor License Agreement.

salesforce-cla[bot] avatar Aug 12 '24 17:08 salesforce-cla[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (9105487) to head (869356b). Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        36    -1     
  Lines         1150      1130   -20     
  Branches        17        17           
=========================================
- Hits          1150      1130   -20     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 12 '24 19:08 codecov[bot]

We have added a workaround fix for the issue. The problem is the need of "composable importmaps", aka an importmap depending on a package that has its own importmap. The workaround involves in copying the dependencies defined in the api importmap into the sample importmap. This can easily be fixed once things are published to JSR, as there is a dependency patching mechanism.

crowlKats avatar Aug 27 '24 15:08 crowlKats