bolt-js icon indicating copy to clipboard operation
bolt-js copied to clipboard

WIP: Add type parameter of event subtype for app.message listeners #796

Open seratch opened this issue 4 years ago • 3 comments

Summary

This pull request shows a possible improvement for #796 use case - better support for message event subtypes in TypeScript. I'm still wondering if there may be a better solution than this one. I would love to get inputs and feedback from anyone who is interested in this topic.

Requirements (place an x in each [ ])

seratch avatar Apr 09 '21 03:04 seratch

Codecov Report

Merging #871 (3256fee) into main (4365f45) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 3256fee differs from pull request most recent head 0fce896. Consider uploading reports for the commit 0fce896 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##             main     #871   +/-   ##
=======================================
  Coverage   66.08%   66.08%           
=======================================
  Files          13       13           
  Lines        1200     1200           
  Branches      353      353           
=======================================
  Hits          793      793           
  Misses        338      338           
  Partials       69       69           
Impacted Files Coverage Δ
src/App.ts 82.76% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4365f45...0fce896. Read the comment docs.

codecov[bot] avatar Apr 09 '21 03:04 codecov[bot]

converted to draft for safety

seratch avatar Apr 09 '21 22:04 seratch

As we are aiming to release v3.4.0 within a few days and this pull request needs more time, let me move this one to v3.5 milestone.

seratch avatar Jun 02 '21 02:06 seratch

Let me close this long-lived but incomplete PR. If someone would like to reuse the code changes in the future, go ahead with it! 🚀

seratch avatar Aug 15 '22 05:08 seratch