bolt-js icon indicating copy to clipboard operation
bolt-js copied to clipboard

Missing documentation of port of customRoutes

Open hidde-jan opened this issue 3 years ago • 1 comments

Description

The documentation for custom HTTP routes does not mention on which port the route will become available.

It will be on the installerOptions.port (which defaults to 3000), but it's easy to think it will be available on the port passed to app.start(), which is confusing.

What type of issue is this? (place an x in one of the [ ])

  • [ ] bug
  • [ ] enhancement (feature request)
  • [ ] question
  • [x] documentation related
  • [ ] example code related
  • [ ] testing related
  • [ ] discussion

Requirements (place an x in each of the [ ])

  • [x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • [x] I've read and agree to the Code of Conduct.
  • [x] I've searched for any related issues and avoided creating a duplicate issue.

hidde-jan avatar Sep 20 '22 13:09 hidde-jan

Hi, @hidde-jan! Thanks for writing in. 😄 I have created a pull request based on the feedback you provided. You can find it here!

hello-ashleyintech avatar Sep 20 '22 21:09 hello-ashleyintech

Fixed by https://github.com/slackapi/bolt-js/pull/1601

seratch avatar Oct 17 '22 08:10 seratch