deno-simple-survey icon indicating copy to clipboard operation
deno-simple-survey copied to clipboard

Swap datastore operations for deno-slack-data-mapper

Open zimeg opened this issue 2 years ago • 3 comments

Type of change

  • [ ] New sample
  • [x] New feature
  • [ ] Bug fix
  • [ ] Documentation

Summary

As an experiment, this PR swaps the native datastore operations for those in the deno-slack-data-mapper module. This comparison shows great simplifications provided for the put, delete, and (especially) query operations.

A note on the required property

The datastore schema properties are currently used as an input property in multiple functions and results in an internal error if the required property is contained in these attributes. To avoid this, additional logic was added to insert the required property for the actual datastore schema while leaving the properties untouched.

Requirements

  • [x] I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • [x] I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • [x] I've read and agree to the Code of Conduct

zimeg avatar Jan 27 '23 22:01 zimeg

I'd like to have a larger discussion about introducing (or not) external libraries into our samples before we go this route

misscoded avatar Jan 27 '23 22:01 misscoded

@misscoded absolutely! Just wanted to test this out and share the findings! Planning on keeping it in draft, but can close it if you'd prefer 😄

zimeg avatar Jan 27 '23 23:01 zimeg

@e-zim Sounds good and I'm glad you're testing it out. And nope, feel free to keep the issue open in the meantime!

misscoded avatar Jan 27 '23 23:01 misscoded