Update API from slack-api-ref@3ec3c10

[github-actions[bot]]

Update API from slack-api-ref. Rev: 3ec3c10 Date: 2024-10-20

[coveralls]

Pull Request Test Coverage Report for Build 13220174908

Details

• 109 of 122 (89.34%) changed or added relevant lines in 10 files are covered.
• 9 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.2%) to 89.348%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/slack/web/api/endpoints/assistant_threads.rb	17	20	85.0%
lib/slack/web/api/endpoints/admin_conversations.rb	7	11	63.64%
lib/slack/web/api/endpoints/conversations_requestSharedInvite.rb	10	16	62.5%
<!--	Total:	109	122

Files with Coverage Reduction	New Missed Lines	%
lib/slack/web/api/endpoints/admin_users_session.rb	1	64.29%
lib/slack/web/api/endpoints/files.rb	8	45.45%
<!--	Total:	9

Totals
Change from base Build 13217187420:	-0.2%
Covered Lines:	5561
Relevant Lines:	6224

---

💛 - Coveralls

[dblock]

Legit failures here that need looking.

  1) Slack::Web::Api::Endpoints::AdminUsersSession admin.users.session_invalidate requires user_id
     Failure/Error: expect { client.admin_users_session_invalidate(session_id: %q[12345]) }.to raise_error ArgumentError, /Required arguments :user_id missing/

       expected ArgumentError with message matching /Required arguments :user_id missing/, got #<ArgumentError: Exactly one of :user_id, :team_id is required> with backtrace:
         # ./lib/slack/web/api/endpoints/admin_users_session.rb:46:in `admin_users_session_invalidate'
         # ./spec/slack/web/api/endpoints/admin_users_session_spec.rb:23:in `block (4 levels) in <top (required)>'
         # ./spec/slack/web/api/endpoints/admin_users_session_spec.rb:23:in `block (3 levels) in <top (required)>'
         # ./vendor/bundle/ruby/3.0.0/gems/webmock-3.24.0/lib/webmock/rspec.rb:39:in `block (2 levels) in <top (required)>'
     # ./spec/slack/web/api/endpoints/admin_users_session_spec.rb:23:in `block (3 levels) in <top (required)>'
     # ./vendor/bundle/ruby/3.0.0/gems/webmock-3.24.0/lib/webmock/rspec.rb:39:in `block (2 levels) in <top (required)>'

[gregsaab]

@dblock can this be merged in prior to file_upload_v2?

[dblock]

@gregsaab I usually do this one before every release, does it need to be?

For file upload v2 I think it's really a utility method that wraps calling an API and doing some more work. It's neither a mixin (something used in many places) nor a patch (something that changes an existing method), so maybe we need a new "helpers" folder/concept (open to other names)?

[gregsaab]

@gregsaab I usually do this one before every release, does it need to be?

For file upload v2 I think it's really a utility method that wraps calling an API and doing some more work. It's neither a mixin (something used in many places) nor a patch (something that changes an existing method), so maybe we need a new "helpers" folder/concept (open to other names)?

When considering the patch approach to adding this method, it seemed wise to have that merged in before making a patch. But, it's not necessary given helper approach.