slack-ruby-client icon indicating copy to clipboard operation
slack-ruby-client copied to clipboard
verified publisher icon slack-ruby

Compatibility with older servers that support #rewind.

Open olleolleolle opened this issue 1 year ago • 17 comments

This PR is an experiment to make slack-ruby-client able to be used with Webrick via rackup gem.

The "rewind-read-rewind" used here:

https://github.com/slack-ruby/slack-ruby-client/blob/9e6d1171aecfb89d11ce55fb010cc3370666cd01/lib/slack/events/request.rb#L39-L47

...is no longer supported.

This change is about making the code compatible with older servers that offered rewind.

olleolleolle avatar Jul 03 '24 11:07 olleolleolle

1 Warning
:warning: There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by :no_entry_sign: Danger

dangerpr-bot avatar Jul 03 '24 11:07 dangerpr-bot

Pull Request Test Coverage Report for Build 9776811795

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 30 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 89.161%
Files with Coverage Reduction New Missed Lines %
spec/slack/real_time/concurrency/clients/async_spec.rb 1 87.5%
spec/slack/real_time/concurrency/with_concurrency_spec.rb 1 80.0%
lib/slack/real_time/concurrency/async.rb 28 1.39%
<!-- Total: 30
Totals Coverage Status
Change from base Build 7789505062: -0.08%
Covered Lines: 5092
Relevant Lines: 5711
💛 - Coveralls

coveralls avatar Jul 03 '24 11:07 coveralls

Pull Request Test Coverage Report for Build 9776811795

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 30 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.002%) to 89.239%
Files with Coverage Reduction New Missed Lines %
spec/slack/real_time/concurrency/clients/async_spec.rb 1 87.5%
spec/slack/real_time/concurrency/with_concurrency_spec.rb 1 80.0%
lib/slack/real_time/concurrency/async.rb 28 1.39%
<!-- Total: 30
Totals Coverage Status
Change from base Build 7789505062: 0.002%
Covered Lines: 5100
Relevant Lines: 5715
💛 - Coveralls

coveralls avatar Jul 03 '24 11:07 coveralls

Pull Request Test Coverage Report for Build 9777240612

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 28 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 89.161%
Files with Coverage Reduction New Missed Lines %
lib/slack/real_time/concurrency/async.rb 28 1.39%
<!-- Total: 28
Totals Coverage Status
Change from base Build 7789505062: -0.08%
Covered Lines: 5092
Relevant Lines: 5711
💛 - Coveralls

coveralls avatar Jul 03 '24 11:07 coveralls

Pull Request Test Coverage Report for Build 9777240612

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 28 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 89.239%
Files with Coverage Reduction New Missed Lines %
lib/slack/real_time/concurrency/async.rb 28 1.39%
<!-- Total: 28
Totals Coverage Status
Change from base Build 7789505062: 0.002%
Covered Lines: 5100
Relevant Lines: 5715
💛 - Coveralls

coveralls avatar Jul 03 '24 11:07 coveralls

Pull Request Test Coverage Report for Build 9777379775

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 89.161%
Totals Coverage Status
Change from base Build 7789505062: -0.08%
Covered Lines: 5092
Relevant Lines: 5711
💛 - Coveralls

coveralls avatar Jul 03 '24 12:07 coveralls

Pull Request Test Coverage Report for Build 9777379775

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 89.239%
Totals Coverage Status
Change from base Build 7789505062: 0.002%
Covered Lines: 5100
Relevant Lines: 5715
💛 - Coveralls

coveralls avatar Jul 03 '24 12:07 coveralls

Pull Request Test Coverage Report for Build 9777483025

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 89.161%
Totals Coverage Status
Change from base Build 7789505062: -0.08%
Covered Lines: 5092
Relevant Lines: 5711
💛 - Coveralls

coveralls avatar Jul 03 '24 12:07 coveralls

Pull Request Test Coverage Report for Build 9777501826

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 28 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 89.161%
Files with Coverage Reduction New Missed Lines %
lib/slack/real_time/concurrency/async.rb 28 1.39%
<!-- Total: 28
Totals Coverage Status
Change from base Build 7789505062: -0.08%
Covered Lines: 5092
Relevant Lines: 5711
💛 - Coveralls

coveralls avatar Jul 03 '24 12:07 coveralls

Pull Request Test Coverage Report for Build 9777501826

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 28 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 89.161%
Files with Coverage Reduction New Missed Lines %
lib/slack/real_time/concurrency/async.rb 28 1.39%
<!-- Total: 28
Totals Coverage Status
Change from base Build 7789505062: -0.08%
Covered Lines: 5092
Relevant Lines: 5711
💛 - Coveralls

coveralls avatar Jul 03 '24 12:07 coveralls

Pull Request Test Coverage Report for Build 9777483025

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 89.239%
Totals Coverage Status
Change from base Build 7789505062: 0.002%
Covered Lines: 5100
Relevant Lines: 5715
💛 - Coveralls

coveralls avatar Jul 03 '24 12:07 coveralls

Pull Request Test Coverage Report for Build 9777483025

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 89.239%
Totals Coverage Status
Change from base Build 7789505062: 0.002%
Covered Lines: 5100
Relevant Lines: 5715
💛 - Coveralls

coveralls avatar Jul 03 '24 12:07 coveralls

Pull Request Test Coverage Report for Build 9777501826

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 28 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 89.239%
Files with Coverage Reduction New Missed Lines %
lib/slack/real_time/concurrency/async.rb 28 1.39%
<!-- Total: 28
Totals Coverage Status
Change from base Build 7789505062: 0.002%
Covered Lines: 5100
Relevant Lines: 5715
💛 - Coveralls

coveralls avatar Jul 03 '24 12:07 coveralls

Pull Request Test Coverage Report for Build 9777677201

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 30 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 89.161%
Files with Coverage Reduction New Missed Lines %
spec/slack/real_time/concurrency/clients/async_spec.rb 1 87.5%
spec/slack/real_time/concurrency/with_concurrency_spec.rb 1 80.0%
lib/slack/real_time/concurrency/async.rb 28 1.39%
<!-- Total: 30
Totals Coverage Status
Change from base Build 7789505062: -0.08%
Covered Lines: 5092
Relevant Lines: 5711
💛 - Coveralls

coveralls avatar Jul 03 '24 12:07 coveralls

Pull Request Test Coverage Report for Build 9777677201

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 30 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 89.161%
Files with Coverage Reduction New Missed Lines %
spec/slack/real_time/concurrency/clients/async_spec.rb 1 87.5%
spec/slack/real_time/concurrency/with_concurrency_spec.rb 1 80.0%
lib/slack/real_time/concurrency/async.rb 28 1.39%
<!-- Total: 30
Totals Coverage Status
Change from base Build 7789505062: -0.08%
Covered Lines: 5092
Relevant Lines: 5711
💛 - Coveralls

coveralls avatar Jul 03 '24 12:07 coveralls

Pull Request Test Coverage Report for Build 9777677201

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 30 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.002%) to 89.239%
Files with Coverage Reduction New Missed Lines %
spec/slack/real_time/concurrency/clients/async_spec.rb 1 87.5%
spec/slack/real_time/concurrency/with_concurrency_spec.rb 1 80.0%
lib/slack/real_time/concurrency/async.rb 28 1.39%
<!-- Total: 30
Totals Coverage Status
Change from base Build 7789505062: 0.002%
Covered Lines: 5100
Relevant Lines: 5715
💛 - Coveralls

coveralls avatar Jul 03 '24 12:07 coveralls

If you don't .rewind you end up with incorrect data, don't you? I think we need an integration test for the various servers at the very least before changing this.

Coveralls is being annoying re-running on every commit... maybe you know how to turn this off?

dblock avatar Jul 03 '24 15:07 dblock