slack-ruby-client icon indicating copy to clipboard operation
slack-ruby-client copied to clipboard
verified publisher icon slack-ruby

Slack::Event::Request#verify! should use secure_compare

Open mintuhouse opened this issue 1 year ago • 1 comments

https://github.com/slack-ruby/slack-ruby-client/blob/9e6d1171aecfb89d11ce55fb010cc3370666cd01/lib/slack/events/request.rb#L62

if using active_support something like ActiveSupport::SecurityUtils.secure_compare

mintuhouse avatar Mar 27 '24 10:03 mintuhouse

Good point, want to PR something along those lines @mintuhouse?

dblock avatar Mar 27 '24 16:03 dblock